Conversation
Co-authored-by: køkkeligk <kebkfdbbd@users.noreply.github.com>
kebkfdbbd
marked this pull request as ready for review
September 14, 2026 22:57
…onflict (superset: main config + deterministic npm ci) Co-authored-by: køkkeligk <kebkfdbbd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a repository-managed Cloud Agent environment (
.cursor/environment.json) so this repo is usable in Cloud Agents, scoped to the Node/TypeScriptServer/component (the WebKit-hostedterminalanddiffViewbundles). The macOS/Xcode app targets require a macOS runner and are out of scope for Linux Cloud Agents.PR #4 already merged this same feature to
main(commit248ba95, "Add Cloud Agent environment config for Server component build"). The only net-new value this PR offers overmainis the deterministicnpm ci --forceinstall (lockfile-based) in place of main'snpm install --force.Maintainer decision needed: either close this PR as superseded, or keep it only for the
npm install→npm ciimprovement.Merge conflict resolution
Merged latest
main. There was one conflict — an add/add on.cursor/environment.json(duplicate intent with PR #4)..github/workflows/github-actions-demo.ymlfrommainmerged cleanly.Resolved as a superset (merge commit
a492ba5):name: "Copilot for Xcode",terminals"Server preview" (python3 -m http.server 8099), andports: [8099].npm ci --force.{ "name": "Copilot for Xcode", "install": "cd Server && npm ci --force && npm run build", "terminals": [{ "name": "Server preview", "command": "cd Server/dist && python3 -m http.server 8099" }], "ports": [8099] }--forceis required becauseServer/package.jsonpins darwin-only@github/copilot-language-server-darwin-*binaries as hard deps; on Linux plainnpm cifailsEBADPLATFORM. The webpack bundles don't import those binaries. Note:npm cirequiresServer/package-lock.jsonto stay in sync withpackage.json.Validation (post-merge)
.cursor/environment.json: valid JSON, no leftover conflict markers.cd Server && npm ci --force && npm run build→ exit 0; webpack compiled (asset-size warnings only).dist/terminal/terminal.jsanddist/diffView/diffView.js.